Properly quote file names in the regexp used to extract backup times. #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a backup filename contains certain special characters, then an exception is thrown when used in the regular expression to extract the time from the backup filename. To protect against this the metaquoting escape sequence (`\Q...\E`) is needed. This fixes issue openwebwork#2680.
… the File Manager. This prevents deletion of files that have parentheses in the name.
drgrice1
force-pushed
the
problem-editor-backup-times-quotemeta
branch
from
02ada58 to
a80be41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a backup filename contains certain special characters, then an exception is thrown when used in the regular expression to extract the time from the backup filename. To protect against this the metaquoting escape sequence (
\Q...\E) is needed.This fixes issue #2680.
Edit: Also allow parenthesis in file names in the file manager. I went to delete the file I created to test the first part of this pull request, and discovered that I could not because the FileManager
checkPWDmethod considers parentheses (or really anything except-_./A-Z0-9~,) to be an illegal character. This probably needs to be revisited. There are lots of other valid characters in file names that this does not allow.