Skip to content

Speed up deleting of global user achievements. #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025
Merged

Speed up deleting of global user achievements. #2710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions lib/WeBWorK/DB.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,17 +1467,8 @@ sub deleteGlobalUserAchievement {
# userAchievementID can be undefined if being called from this package
my $U = caller eq __PACKAGE__ ? "!" : "";
my ($self, $userID) = shift->checkArgs(\@_, "user_id$U");

my @achievements = $self->listUserAchievements($userID);
foreach my $achievement (@achievements) {
$self->deleteUserAchievement($userID, $achievement);
}

if ($self->{global_user_achievement}) {
return $self->{global_user_achievement}->delete($userID);
} else {
return 0;
}
$self->{achievement_user}->delete_where({ user_id => $userID });
return $self->{global_user_achievement}->delete($userID);
}

################################################################################
Expand Down