Skip to content

[fix:tests] Extended controller app tests part one #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
asmodehn wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

[fix:tests] Extended controller app tests part one #362

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
11d3a3c
[change] Add controller config and connection apps
Nov 28, 2025
706966e
[change] Adjust tests and sample apps
Dec 1, 2025
72e9d2c
[change] Remove sample_config for now
Dec 1, 2025
088a978
Merge branch 'master' into extended_controller_app_tests_part_one
nemesifier Dec 27, 2025
7c1f2a7
[change] Formatting
Dec 29, 2025
df6a7dc
[change] Remove comments and commented accounts/ in tests/openwisp/ur…
Dec 30, 2025
87d9f97
[change] Remove comments regarding config from tests settings
Dec 30, 2025
0aaba03
[change] Simplify sample_connection.tests.TestNotifications
Jan 12, 2026
218ebf5
[change] Merge branch 'master' into extended_controller_app_tests_par…
Mar 4, 2026
4bb164c
[change] Remove unused connection_app_label in test_admin.BaseTestAdmin
Mar 4, 2026
89ce2c3
[change] Merge branch 'master' into extended_controller_app_tests_par…
Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
715 changes: 372 additions & 343 deletions openwisp_firmware_upgrader/tests/test_admin.py
View file
Open in desktop

Large diffs are not rendered by default.

154 changes: 77 additions & 77 deletions openwisp_firmware_upgrader/tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,69 +544,69 @@ class TestModelsTransaction(TestUpgraderMixin, TransactionTestCase):
image_type = TestModels.image_type

@mock.patch(_mock_updrade, return_value=True)
@mock.patch(_mock_connect, return_value=True)
def test_dry_run(self, *args):
env = self._create_upgrade_env()
# check pending upgrades
result = BatchUpgradeOperation.dry_run(build=env["build1"])
self.assertEqual(
list(result["device_firmwares"]),
list(DeviceFirmware.objects.all().order_by("-created")),
)
self.assertEqual(list(result["devices"]), [])
# upgrade devices
env["build1"].batch_upgrade(firmwareless=True)
# check pending upgrades again
result = BatchUpgradeOperation.dry_run(build=env["build1"])
self.assertEqual(list(result["device_firmwares"]), [])
self.assertEqual(list(result["devices"]), [])
with mock.patch(self._mock_connect, return_value=True):
env = self._create_upgrade_env()
# check pending upgrades
result = BatchUpgradeOperation.dry_run(build=env["build1"])
self.assertEqual(
list(result["device_firmwares"]),
list(DeviceFirmware.objects.all().order_by("-created")),
)
self.assertEqual(list(result["devices"]), [])
# upgrade devices
env["build1"].batch_upgrade(firmwareless=True)
# check pending upgrades again
result = BatchUpgradeOperation.dry_run(build=env["build1"])
self.assertEqual(list(result["device_firmwares"]), [])
self.assertEqual(list(result["devices"]), [])

@mock.patch(_mock_updrade, return_value=True)
@mock.patch(_mock_connect, return_value=True)
def test_upgrade_related_devices(self, *args):
env = self._create_upgrade_env()
# check everything is as expected
self.assertEqual(UpgradeOperation.objects.count(), 0)
self.assertEqual(env["d1"].devicefirmware.image, env["image1a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image1b"])
# upgrade all related
env["build2"].batch_upgrade(firmwareless=False)
# ensure image is changed
env["d1"].devicefirmware.refresh_from_db()
env["d2"].devicefirmware.refresh_from_db()
self.assertEqual(env["d1"].devicefirmware.image, env["image2a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image2b"])
# ensure upgrade operation objects have been created
self.assertEqual(UpgradeOperation.objects.count(), 2)
batch_qs = BatchUpgradeOperation.objects.all()
self.assertEqual(batch_qs.count(), 1)
batch = batch_qs.first()
self.assertEqual(batch.upgradeoperation_set.count(), 2)
self.assertEqual(batch.build, env["build2"])
self.assertEqual(batch.status, "success")
with mock.patch(self._mock_connect, return_value=True):
env = self._create_upgrade_env()
# check everything is as expected
self.assertEqual(UpgradeOperation.objects.count(), 0)
self.assertEqual(env["d1"].devicefirmware.image, env["image1a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image1b"])
# upgrade all related
env["build2"].batch_upgrade(firmwareless=False)
# ensure image is changed
env["d1"].devicefirmware.refresh_from_db()
env["d2"].devicefirmware.refresh_from_db()
self.assertEqual(env["d1"].devicefirmware.image, env["image2a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image2b"])
# ensure upgrade operation objects have been created
self.assertEqual(UpgradeOperation.objects.count(), 2)
batch_qs = BatchUpgradeOperation.objects.all()
self.assertEqual(batch_qs.count(), 1)
batch = batch_qs.first()
self.assertEqual(batch.upgradeoperation_set.count(), 2)
self.assertEqual(batch.build, env["build2"])
self.assertEqual(batch.status, "success")

@mock.patch(_mock_updrade, return_value=True)
@mock.patch(_mock_connect, return_value=True)
def test_upgrade_firmwareless_devices(self, *args):
env = self._create_upgrade_env(device_firmware=False)
# check everything is as expected
self.assertEqual(UpgradeOperation.objects.count(), 0)
self.assertFalse(hasattr(env["d1"], "devicefirmware"))
self.assertFalse(hasattr(env["d2"], "devicefirmware"))
# upgrade all related
env["build2"].batch_upgrade(firmwareless=True)
env["d1"].refresh_from_db()
env["d2"].refresh_from_db()
self.assertEqual(env["d1"].devicefirmware.image, env["image2a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image2b"])
# ensure upgrade operation objects have been created
self.assertEqual(UpgradeOperation.objects.count(), 2)
batch_qs = BatchUpgradeOperation.objects.all()
self.assertEqual(batch_qs.count(), 1)
batch = batch_qs.first()
self.assertEqual(batch.upgradeoperation_set.count(), 2)
self.assertEqual(batch.build, env["build2"])
self.assertEqual(batch.status, "success")
with mock.patch(self._mock_connect, return_value=True):
env = self._create_upgrade_env(device_firmware=False)
# check everything is as expected
self.assertEqual(UpgradeOperation.objects.count(), 0)
self.assertFalse(hasattr(env["d1"], "devicefirmware"))
self.assertFalse(hasattr(env["d2"], "devicefirmware"))
# upgrade all related
env["build2"].batch_upgrade(firmwareless=True)
env["d1"].refresh_from_db()
env["d2"].refresh_from_db()
self.assertEqual(env["d1"].devicefirmware.image, env["image2a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image2b"])
# ensure upgrade operation objects have been created
self.assertEqual(UpgradeOperation.objects.count(), 2)
batch_qs = BatchUpgradeOperation.objects.all()
self.assertEqual(batch_qs.count(), 1)
batch = batch_qs.first()
self.assertEqual(batch.upgradeoperation_set.count(), 2)
self.assertEqual(batch.build, env["build2"])
self.assertEqual(batch.status, "success")

@mock.patch.object(upgrade_firmware, "max_retries", 0)
def test_batch_upgrade_failure(self):
Expand All @@ -618,28 +618,28 @@ def test_batch_upgrade_failure(self):
self.assertEqual(BatchUpgradeOperation.objects.count(), 1)

@mock.patch(_mock_updrade, return_value=True)
@mock.patch(_mock_connect, return_value=True)
def test_upgrade_related_devices_existing_fw(self, *args):
env = self._create_upgrade_env()
self.assertEqual(UpgradeOperation.objects.count(), 0)
self.assertEqual(env["d1"].devicefirmware.image, env["image1a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image1b"])
env["d1"].devicefirmware.installed = False
env["d1"].devicefirmware.save(upgrade=False)
env["d2"].devicefirmware.installed = False
env["d2"].devicefirmware.save(upgrade=False)
env["build1"].batch_upgrade(firmwareless=False)
env["d1"].devicefirmware.refresh_from_db()
env["d2"].devicefirmware.refresh_from_db()
self.assertEqual(env["d1"].devicefirmware.image, env["image1a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image1b"])
self.assertEqual(UpgradeOperation.objects.count(), 2)
batch_qs = BatchUpgradeOperation.objects.all()
self.assertEqual(batch_qs.count(), 1)
batch = batch_qs.first()
self.assertEqual(batch.upgradeoperation_set.count(), 2)
self.assertEqual(batch.build, env["build1"])
self.assertEqual(batch.status, "success")
with mock.patch(self._mock_connect, return_value=True):
env = self._create_upgrade_env()
self.assertEqual(UpgradeOperation.objects.count(), 0)
self.assertEqual(env["d1"].devicefirmware.image, env["image1a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image1b"])
env["d1"].devicefirmware.installed = False
env["d1"].devicefirmware.save(upgrade=False)
env["d2"].devicefirmware.installed = False
env["d2"].devicefirmware.save(upgrade=False)
env["build1"].batch_upgrade(firmwareless=False)
env["d1"].devicefirmware.refresh_from_db()
env["d2"].devicefirmware.refresh_from_db()
self.assertEqual(env["d1"].devicefirmware.image, env["image1a"])
self.assertEqual(env["d2"].devicefirmware.image, env["image1b"])
self.assertEqual(UpgradeOperation.objects.count(), 2)
batch_qs = BatchUpgradeOperation.objects.all()
self.assertEqual(batch_qs.count(), 1)
batch = batch_qs.first()
self.assertEqual(batch.upgradeoperation_set.count(), 2)
self.assertEqual(batch.build, env["build1"])
self.assertEqual(batch.status, "success")

def test_upgrade_retried(self):
env = self._create_upgrade_env()
Expand Down
Loading
Loading