Skip to content

[chores] Updated Twitter reference to X #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemesifier merged 14 commits into from
May 18, 2026
+45 −45
Merged

[chores] Updated Twitter reference to X #1046

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
899979a
X Social Added
Ayush4958 Mar 2, 2026
6aca583
X Social Added
Ayush4958 Mar 2, 2026
1c329b7
Merge branch 'master' into master
nemesifier Mar 7, 2026
56da3cc
[fix] Update snapshots for login, password-confirm and contact-box #1046
Ayush4958 Mar 8, 2026
c696a4f
Merge branch 'master' into master
Ayush4958 Mar 12, 2026
97ba36e
Merge branch 'master' into master
Ayush4958 Mar 15, 2026
54fa77b
Merge branch 'master' into master
nemesifier Mar 24, 2026
b074f80
[chores] Fixed icon
nemesifier Mar 24, 2026
d6a632d
[chores] Renamed X to x
nemesifier Mar 24, 2026
35b487b
Merge branch 'openwisp:master' into master
Ayush4958 Mar 29, 2026
ec0e356
[fix] Update snapshots for login, password-confirm, and contact-box #…
Ayush4958 Mar 30, 2026
942604f
[fix] Update snapshots for login, password-confirm, and contact-box #…
Ayush4958 Mar 30, 2026
854d58a
Merge branch 'master' into master
nemesifier May 18, 2026
5c18730
[qa] Fixed QA format
nemesifier May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions client/components/contact-box/__snapshots__/contact.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,14 @@ exports[`<Contact /> rendering with placeholder translation tags should render t
>
<a
className="link "
href="https://twitter.com/openwisp"
href="https://X.com/openwisp"
rel="noopener noreferrer"
target="_blank"
>
<img
alt="twitter"
alt="X"
className="contact-image "
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
</a>
<a
Expand Down Expand Up @@ -115,14 +115,14 @@ exports[`<Status /> rendering should render correctly 1`] = `
>
<a
className="link "
href="https://twitter.com/openwisp"
href="https://X.com/openwisp"
rel="noopener noreferrer"
target="_blank"
>
<img
alt="twitter"
alt="X"
className="contact-image "
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
</a>
<a
Expand Down
12 changes: 6 additions & 6 deletions client/components/contact-box/contact.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ jest.mock("../../utils/load-translation");
const defaultConfig = getConfig("default", true);
const links = [
{
alt: {en: "twitter"},
icon: "twiter.svg",
url: "https://twitter.com/openwisp",
alt: {en: "X"},
icon: "X.svg",
url: "https://X.com/openwisp",
authenticated: true,
css: "twitter",
css: "X",
},
{
alt: {en: "facebook"},
Expand Down Expand Up @@ -69,7 +69,7 @@ describe("<Status /> rendering", () => {
expect(wrapper.find(".contact-image")).toHaveLength(2);
expect(wrapper.find(".link.google")).toHaveLength(1);
expect(wrapper.find(".link.facebook")).toHaveLength(1);
expect(wrapper.find(".link.twitter")).toHaveLength(0);
expect(wrapper.find(".link.X")).toHaveLength(0);
});

it("should render with authenticated links when authenticated", () => {
Expand All @@ -79,7 +79,7 @@ describe("<Status /> rendering", () => {
const wrapper = shallow(<Contact {...props} />);
expect(wrapper.find(".contact-image")).toHaveLength(2);
expect(wrapper.find(".link.google")).toHaveLength(1);
expect(wrapper.find(".link.twitter")).toHaveLength(1);
expect(wrapper.find(".link.X")).toHaveLength(1);
expect(wrapper.find(".link.facebook")).toHaveLength(0);
});
});
38 changes: 19 additions & 19 deletions client/components/login/__snapshots__/login.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ exports[`<Login /> interactions phone_number field should be present if mobile p
<p>
<a
class="social-link button full"
href="#twitter"
href="#X"
rel="noopener noreferrer"
>
<span
Expand All @@ -73,7 +73,7 @@ exports[`<Login /> interactions phone_number field should be present if mobile p
<img
alt="Login with X"
class="icon"
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
<span
class="text"
Expand Down Expand Up @@ -275,14 +275,14 @@ exports[`<Login /> interactions phone_number field should be present if mobile p
>
<a
class="link "
href="https://twitter.com/openwisp"
href="https://X.com/openwisp"
rel="noopener noreferrer"
target="_blank"
>
<img
alt="twitter"
alt="X"
class="contact-image "
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
</a>
<a
Expand Down Expand Up @@ -368,7 +368,7 @@ exports[`<Login /> interactions should not show phone_number field if auto_switc
<p>
<a
class="social-link button full"
href="#twitter"
href="#X"
rel="noopener noreferrer"
>
<span
Expand All @@ -377,7 +377,7 @@ exports[`<Login /> interactions should not show phone_number field if auto_switc
<img
alt="Login with X"
class="icon"
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
<span
class="text"
Expand Down Expand Up @@ -553,14 +553,14 @@ exports[`<Login /> interactions should not show phone_number field if auto_switc
>
<a
class="link "
href="https://twitter.com/openwisp"
href="https://X.com/openwisp"
rel="noopener noreferrer"
target="_blank"
>
<img
alt="twitter"
alt="X"
class="contact-image "
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
</a>
<a
Expand Down Expand Up @@ -646,7 +646,7 @@ exports[`<Login /> interactions username should be text field if mobile phone ve
<p>
<a
class="social-link button full"
href="#twitter"
href="#X"
rel="noopener noreferrer"
>
<span
Expand All @@ -655,7 +655,7 @@ exports[`<Login /> interactions username should be text field if mobile phone ve
<img
alt="Login with X"
class="icon"
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
<span
class="text"
Expand Down Expand Up @@ -831,14 +831,14 @@ exports[`<Login /> interactions username should be text field if mobile phone ve
>
<a
class="link "
href="https://twitter.com/openwisp"
href="https://X.com/openwisp"
rel="noopener noreferrer"
target="_blank"
>
<img
alt="twitter"
alt="X"
class="contact-image "
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"

@nemesifier nemesifier Mar 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src="/assets/default/X.svg"
src="/assets/default/x.svg"

Applies to all other occurrences

@Ayush4958 Ayush4958 Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed

/>
</a>
<a
Expand Down Expand Up @@ -1171,7 +1171,7 @@ exports[`<Login /> rendering should render correctly without social links 1`] =
<p>
<a
className="social-link button full"
href="#twitter"
href="#X"
rel="noopener noreferrer"
>
<span
Expand All @@ -1180,7 +1180,7 @@ exports[`<Login /> rendering should render correctly without social links 1`] =
<img
alt="Login with X"
className="icon"
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
<span
className="text"
Expand Down Expand Up @@ -1423,7 +1423,7 @@ exports[`<Login /> rendering with placeholder translation tags should render tra
<p>
<a
className="social-link button full"
href="#twitter"
href="#X"
rel="noopener noreferrer"
>
<span
Expand All @@ -1432,7 +1432,7 @@ exports[`<Login /> rendering with placeholder translation tags should render tra
<img
alt="Login with X"
className="icon"
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
<span
className="text"
Expand Down
6 changes: 3 additions & 3 deletions client/components/password-confirm/__snapshots__/password-confirm.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,14 +160,14 @@ exports[`<PasswordConfirm /> rendering should render correctly 1`] = `
>
<a
className="link "
href="https://twitter.com/openwisp"
href="https://X.com/openwisp"

@nemesifier nemesifier Mar 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
href="https://X.com/openwisp"
href="https://x.com/openwisp"

applies to all other occurrences

@Ayush4958 Ayush4958 Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry late answering , I had made the changes

rel="noopener noreferrer"
target="_blank"
>
<img
alt="twitter"
alt="X"
className="contact-image "
src="/assets/default/twitter.svg"
src="/assets/default/X.svg"
/>
</a>
<a
Expand Down
3 changes: 3 additions & 0 deletions organizations/default/client_assets/X.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions organizations/default/default.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,9 @@ client:
helpdesk: "+789 948 564"
social_links:
- alt:
en: "twitter"
icon: "twitter.svg"
url: "https://twitter.com/openwisp"
en: "X"
icon: "X.svg"
url: "https://X.com/openwisp"
- alt:
en: "facebook"
icon: "facebook.svg"
Expand All @@ -161,8 +161,8 @@ client:
url: "#google"
- text:
en: "Login with X"
icon: "twitter.svg"
url: "#twitter"
icon: "X.svg"
url: "#X"
input_fields:
username:
type: "email"
Expand Down
Loading