[tests] Make add-org interactive test catch config creation regressions#1061
[tests] Make add-org interactive test catch config creation regressions#1061czarflix wants to merge 1 commit into
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add a regression test for the successful interactive add-org flow so the suite fails when config creation is skipped. Closes openwisp#880
984fb1d to
9d59781
Compare
|
Hi @nemesifier , please take a look when you have the time |
|
@nemesifier , ready for review when you have the time |
Checklist
Reference to Existing Issue
Closes #880.
Description of Changes
The existing interactive add-org test was only a smoke test, so commenting out
createConfiguration(response)increateConfigurationWithPrompts()still leftthe focused test suite green.
This updates
config/__tests__/add-org.test.jsto add a regression test that:The existing smoke test is kept and no application code is changed.
Verification
yarn jest config/__tests__/add-org.test.js --runInBand./run-qa-checkscreateConfiguration(response)is commented outyarn test --runInBandwas compared against untouchedorigin/master; the observed login/header failures are preexisting and unrelated to this changeScreenshot
N/A - test-only change