[deps] Bump react-cookie from 4.1.1 to 8.0.1#860
Merged
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-cookie-8.0.1
branch
5 times, most recently
from
1c9c4c6 to
54af0db
Compare
Member
|
@dependabot rebase |
Contributor
Author
|
Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
Member
|
@dependabot recreate |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-cookie-8.0.1
branch
from
54af0db to
ff37c81
Compare
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-cookie-8.0.1
branch
from
ff37c81 to
2c080dc
Compare
Bumps [react-cookie](https://github.com/bendotcodes/cookies) from 4.1.1 to 8.0.1. - [Release notes](https://github.com/bendotcodes/cookies/releases) - [Changelog](https://github.com/bendotcodes/cookies/blob/main/LEGACY-CHANGELOG.md) - [Commits](https://github.com/bendotcodes/cookies/commits/v8.0.1) --- updated-dependencies: - dependency-name: react-cookie dependency-version: 8.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/react-cookie-8.0.1
branch
from
2c080dc to
f6fcc47
Compare
Member
|
@dependabot rebase |
Contributor
Author
|
Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request |
pandafy
force-pushed
the
dependabot/npm_and_yarn/react-cookie-8.0.1
branch
from
aab89d2 to
c31d11d
Compare
The `Cookies` object returned by `react-cookie` now includes additional internal properties and methods (i.e.., `defaultSetOptions`, `update`), which caused strict `toHaveBeenCalledWith` checks to fail. Refactored tests to assert `Cookies` instances using `expect.any(Cookies)` and verified internal cookie values explicitly.
pandafy
force-pushed
the
dependabot/npm_and_yarn/react-cookie-8.0.1
branch
from
c31d11d to
b703d3f
Compare
pandafy
reviewed
Apr 23, 2025
Comment on lines
-1369
to
+1371
| expect(prop.logout).toHaveBeenCalledWith( | ||
| { | ||
| HAS_DOCUMENT_COOKIE: true, | ||
| changeListeners: [], | ||
| cookies: {default_macaddr: "4e:ed:11:2b:17:ae"}, | ||
| }, | ||
| "default", | ||
| ); | ||
| expect(prop.logout).toHaveBeenCalledWith(expect.any(Cookies), "default"); | ||
| const cookiesArg = prop.logout.mock.calls[0][0]; | ||
| expect(cookiesArg.cookies).toEqual({default_macaddr: "4e:ed:11:2b:17:ae"}); |
Member
There was a problem hiding this comment.
The Cookies object returned by react-cookie now includes additional
internal properties and methods (i.e.., defaultSetOptions, update),
which caused strict toHaveBeenCalledWith checks to fail.
Refactored tests to assert Cookies instances using expect.any(Cookies)
and verified internal cookie values explicitly.
github-project-automation
Bot
moved this to To do (general)
in OpenWISP Contributor's Board
pandafy
moved this from To do (general)
to Needs review
in OpenWISP Contributor's Board
nemesifier
approved these changes
Apr 23, 2025
github-project-automation
Bot
moved this from Needs review
to In progress
in OpenWISP Contributor's Board
github-project-automation
Bot
moved this from In progress
to Done
in OpenWISP Contributor's Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps react-cookie from 4.1.1 to 8.0.1.
Release notes
Sourced from react-cookie's releases.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)