Push shardy inliner down past ShardingGroupImport pass for late inlining.#1181
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Push shardy inliner down past ShardingGroupImport pass for late inlining.#1181copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_900063289
branch
2 times, most recently
from
3445746 to
814c855
Compare
copybara-service
bot
changed the title
…ing. ShardingGroupImport walks on sharding groups and verifies the groupings and simplifies their group numbers and erases duplicates. The pass does not do anything specific for ShardableDataFlowOps generally neither for NamedComputationOps specifically. Inlining and not-inlining should not impact the pass. PiperOrigin-RevId: 900063289
copybara-service
bot
force-pushed
the
test_900063289
branch
from
814c855 to
d75512b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push shardy inliner down past ShardingGroupImport pass for late inlining.
ShardingGroupImport walks on sharding groups and verifies the groupings and simplifies their group numbers and erases duplicates. The pass does not do anything specific for ShardableDataFlowOps generally neither for NamedComputationOps specifically. Inlining and not-inlining should not impact the pass.