Push shardy outliner up past CloseShardings pass.#1184
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Push shardy outliner up past CloseShardings pass.#1184copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
CloseShardings closes shardings. It is a pure transformation on shardings on the module, meanining it only impacts the shardings, and covers all shardings on the module. Such pure transformations are walked on the module/func and covers all func input/output shardings, call result shardings (generically as Operation) and named-computations as ShardableDataFlowOp. Hence, such pure transformations are not impacted on inlining and non-inlining. [1] PiperOrigin-RevId: 900123673
copybara-service
bot
force-pushed
the
test_900123673
branch
from
47b1382 to
94471d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push shardy outliner up past CloseShardings pass.
CloseShardings closes shardings. It is a pure transformation on shardings on the module, meanining it only impacts the shardings, and covers all shardings on the module. Such pure transformations are walked on the module/func and covers all func input/output shardings, call result shardings (generically as Operation) and named-computations as ShardableDataFlowOp. Hence, such pure transformations are not impacted on inlining and non-inlining. [1]