Push shardy outliner up past RemoveSubAxesInInputOutputShardings pass.#1185
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Push shardy outliner up past RemoveSubAxesInInputOutputShardings pass.#1185copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_900127894
branch
from
be813c2 to
7aeaaf5
Compare
RemoveSubAxesInInputOutputShardingsPass runs for all functions. Before this change, it runs only for the main func because the module is an inlined one. Hence, in order to keep the behavior the same, on this change, it should explicitly run it on the main func. This CL should not change the behaviour. PiperOrigin-RevId: 900127894
copybara-service
bot
force-pushed
the
test_900127894
branch
from
7aeaaf5 to
d41e8b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push shardy outliner up past RemoveSubAxesInInputOutputShardings pass.
RemoveSubAxesInInputOutputShardingsPass runs for all functions. Before this change, it runs only for the main func because the module is an inlined one. Hence, in order to keep the behavior the same, on this change, it should explicitly run it on the main func.
This CL should not change the behaviour.