[SDY] Add versioned serialization support for SDY dialect in PJRT.#1190
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
[SDY] Add versioned serialization support for SDY dialect in PJRT.#1190copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_899101032
branch
6 times, most recently
from
82fb06e to
fd2da21
Compare
This change introduces versioning utilities to the SDY dialect, including minimum supported versions and compatibility requirements, similar to StableHlo. Unlike StableHlo, SDY does not track the MLIR Bytecode Format. PjRt `SerializeUsingVersionedStablehlo()` function is updated to accept an optional SDY dialect version, allowing for the downgrading of SDY ops/attrs (if needed) during mixed StableHLO/SDY serialization. A new test case runs smoke testing as there are currently no SDY ops/attrs that have downgrade options. `IfrtAtomProgramsToVhloPass` is also updated to optionally downgrade the module for a lower target SDY version. Includes minor code cleanups to follow the Google C++ code style. PiperOrigin-RevId: 899101032
copybara-service
bot
force-pushed
the
test_899101032
branch
from
fd2da21 to
90bda45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SDY] Add versioned serialization support for SDY dialect in PJRT.
This change introduces versioning utilities to the SDY dialect, including minimum supported versions and compatibility requirements, similar to StableHlo. Unlike StableHlo, SDY does not track the MLIR Bytecode Format.
PjRt
SerializeUsingVersionedStablehlo()function is updated to accept an optional SDY dialect version, allowing for the downgrading of SDY ops/attrs (if needed) during mixed StableHLO/SDY serialization. A new test case runs smoke testing as there are currently no SDY ops/attrs that have downgrade options.IfrtAtomProgramsToVhloPassis also updated to optionally downgrade the module for a lower target SDY version.Includes minor code cleanups to follow the Google C++ code style.