Push shardy outliner up past ConstantOrScalarMerger pass.#1195
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Push shardy outliner up past ConstantOrScalarMerger pass.#1195copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
2403602 to
5fc120b
Compare
ConstantOrScalarMerger combines constants and constant-likes that are sharded the same way. It is not critical for final performance but it is important to keep the graph smaller. Hence, unlike ConstantOrScalarSplitter, it does not take NamedComputations/Funcs/Calls as parts of constant expressions. PiperOrigin-RevId: 900633218
5fc120b to
4d22c42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Push shardy outliner up past ConstantOrScalarMerger pass.
ConstantOrScalarMerger combines constants and constant-likes that are sharded the same way. It is not critical for final performance but it is important to keep the graph smaller. Hence, unlike ConstantOrScalarSplitter, it does not take NamedComputations/Funcs/Calls as parts of constant expressions.