Skip to content

Push shardy inliner down past ShardingGroupImport pass for early inliner. #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 24, 2026
+4 −4
Merged

Push shardy inliner down past ShardingGroupImport pass for early inliner. #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions shardy/dialect/sdy/transforms/import/import_pipeline.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ void addImportPipeline(OpPassManager& pm, int& dumpIndex,
pm.addPass(
createApplyShardingConstraintsPass(ApplyShardingConstraintsPassOptions{
options.debugShardingOrigins, options.debugPropagationEdgeSharding}));
// The sharding group import pass must run after applying sharding
// constraints. This ensures we can detect sharding conflicts between group
// members which have pre-propagation shardings due to sharding constraints.
pm.addPass(createShardingGroupImportPass());
if (!options.enableLateInlining) {
pm.addPass(createImportFuncCallsPass());
// Keep SymbolDCEPass after ImportFuncCallsPass.
pm.addPass(createSymbolDCEPass());
}
// The sharding group import pass must run after applying sharding
// constraints. This ensures we can detect sharding conflicts between group
// members which have pre-propagation shardings due to sharding constraints.
pm.addPass(createShardingGroupImportPass());
}

void addImportPipeline(OpPassManager& pm, const PropagationOptions& options) {
Expand Down
Loading