Skip to content

Push shardy inliner down out of shardy-import pipeline for early inliner. #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Apr 24, 2026
Merged

Push shardy inliner down out of shardy-import pipeline for early inliner. #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions shardy/dialect/sdy/transforms/import/import_pipeline.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@ void addImportPipeline(OpPassManager& pm, int& dumpIndex,
// constraints. This ensures we can detect sharding conflicts between group
// members which have pre-propagation shardings due to sharding constraints.
pm.addPass(createShardingGroupImportPass());
if (!options.enableLateInlining) {
pm.addPass(createImportFuncCallsPass());
// Keep SymbolDCEPass after ImportFuncCallsPass.
pm.addPass(createSymbolDCEPass());
}
}

void addImportPipeline(OpPassManager& pm, const PropagationOptions& options) {
Expand Down
98 changes: 0 additions & 98 deletions shardy/dialect/sdy/transforms/import/test/import_pipeline_enable_late_inlining_false.mlir
View file
Open in desktop

This file was deleted.

8 changes: 3 additions & 5 deletions shardy/dialect/sdy/transforms/propagation/propagation_pipeline.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,9 @@ void populateExportOptions(ExportOptions& options,
void addPropagationPipeline(OpPassManager& pm, int& dumpIndex,
const PropagationOptions& options) {
addImportPipeline(pm, dumpIndex, options);
if (options.enableLateInlining) {
pm.addPass(createImportFuncCallsPass());
// Keep SymbolDCEPass after ImportFuncCallsPass.
pm.addPass(createSymbolDCEPass());
}
pm.addPass(createImportFuncCallsPass());
// Keep SymbolDCEPass after ImportFuncCallsPass.
pm.addPass(createSymbolDCEPass());
{
PropagationOptions optionsWithKeepShardingRules = options;
optionsWithKeepShardingRules.keepShardingRules = true;
Expand Down
Loading
Loading