Fix op sharding rule for stablehlo.scatter.#1257
Closed
copybara-service[bot] wants to merge 0 commit intomainfrom
Closed
Fix op sharding rule for stablehlo.scatter.#1257copybara-service[bot] wants to merge 0 commit intomainfrom
copybara-service[bot] wants to merge 0 commit intomainfrom
Conversation
copybara-service
Bot
force-pushed
the
test_907780335
branch
from
b8d980f to
c0abfd2
Compare
copybara-service
Bot
force-pushed
the
test_907780335
branch
from
c0abfd2 to
cf75920
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix op sharding rule for stablehlo.scatter.
For stablehlo.scatter, an input dim can correspond to an output dim through
the update_window_dims attribute. When these two corresponding dims don’t have
the same sizes, we currently mark the input dim as kPassThrough and the output dim
as kNeedReplication. This would lead to a local scatter op that partitions the
input but not the output, which doesn't preserve the semantics of the original
op.