[mpmd] Do not rename axes in GenerateSdyMeshesFromTopologyPass.#795
Merged
copybara-service[bot] merged 1 commit intomainfrom Oct 2, 2025
Merged
[mpmd] Do not rename axes in GenerateSdyMeshesFromTopologyPass.#795copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
6c034c0 to
51b5e6b
Compare
Keep the mesh name prefix in the axis name so that with_sharding_constraint works as expected. PiperOrigin-RevId: 814188128
51b5e6b to
af26707
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[mpmd] Do not rename axes in GenerateSdyMeshesFromTopologyPass.
Keep the mesh name prefix in the axis name so that with_sharding_constraint works as expected.