[complex-math-expander] Add basic complex arithmetic decomposition#2929
Draft
ddilbazTT wants to merge 7 commits intoopenxla:mainfrom
Draft
[complex-math-expander] Add basic complex arithmetic decomposition#2929ddilbazTT wants to merge 7 commits intoopenxla:mainfrom
ddilbazTT wants to merge 7 commits intoopenxla:mainfrom
Conversation
…y regenerating them. build/bin/stablehlo-opt --chlo-legalize-to-stablehlo --split-input-file --verify-diagnostics stablehlo/tests/chlo/chlo_legalize_to_stablehlo.mlir | python3 llvm-project/mlir/utils/generate-test-checks.py --source stablehlo/tests/chlo/chlo_legalize_to_stablehlo.mlir -i 2>&1
…after this commit
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Member
|
Approach LGTM! Let me know when ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2913
It would be ideal for Stablehlo Complex Math Expander Pass to be able to decompose common arithmetic operations in complex domain to real domain. For example: (a + bi) * (c + di) = (ac - bd) + (bc + ad)i
In this draft PR, I wanted to showcase how we could go about
defaultvsfullcomplex math expansion.I have added
stablehlo/transforms/StablehloComplexFullMathExpanderPatterns.tdwhich showcases an example of how to add multiplication expansion. The following files were changed accordingly:build_tools/math/generate_tests.pystablehlo/transforms/CMakeLists.txtstablehlo/transforms/StablehloComplexMathExpander.cppIt would be great to have input on this method before moving forward. @GleasonK I would appreciate your review on this proposal.