Skip to content

[XLA:GPU] [plugin] Adding sycl/oneapi plugin support for Intel GPU #35304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ashiqimranintel wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[XLA:GPU] [plugin] Adding sycl/oneapi plugin support for Intel GPU #35304

ashiqimranintel wants to merge 7 commits into from

Conversation

@ashiqimranintel
Copy link
Contributor

@ashiqimranintel ashiqimranintel commented Dec 15, 2025

This PR will enable sycl/oneapi plugin support for Intel GPU

@penpornk penpornk requested a review from beckerhe December 16, 2025 17:04
beckerhe
beckerhe reviewed Dec 17, 2025
View reviewed changes
Copy link
Member

@beckerhe beckerhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Thank you!

xla/pjrt/c/pjrt_c_api_gpu_internal.cc Outdated
xla::PjRtPlatformId platform_id;
std::string platform_name;

std::string plugin_platform = std::string(PJRT_GPU_PLUGIN_PLATFORM_NAME);
Copy link
Member

@beckerhe beckerhe Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this an absl::string_view?

Copy link
Contributor Author

@ashiqimranintel ashiqimranintel Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

xla/pjrt/c/pjrt_c_api_gpu_test.cc Outdated
#ifdef TENSORFLOW_USE_ROCM
if (allocator_option == "cuda_async") {
VLOG(1) << "cuda_async allocator not available on ROCm!";
VLOG(1) << "cuda_async allocator not available on ROCm! and SYCL!";
Copy link
Member

@beckerhe beckerhe Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: There is an exclamation mark too many.

Copy link
Contributor Author

@ashiqimranintel ashiqimranintel Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

copybara-service bot pushed a commit that referenced this pull request Jan 7, 2026
@ashiqimranintel @Google-ML-Automation
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
46eefd7 
…ntel GPU

Imported from GitHub PR #35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a2 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd
PiperOrigin-RevId: 853258690
@copybara-service copybara-service bot mentioned this pull request Jan 7, 2026
Closed
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 7, 2026
@ashiqimranintel @tensorflower-gardener
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
a48dc16 
…ntel GPU

Imported from GitHub PR openxla/xla#35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a21e9e59c38e961ccd68b036a2c52403728 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1abcd5b84fc503fdc6a2502adeebf813d4 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd19d4e6ba9d521003b4f047e687feffd3d by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd19d4e6ba9d521003b4f047e687feffd3d
PiperOrigin-RevId: 853258690
@copybara-service copybara-service bot mentioned this pull request Jan 7, 2026
Draft
copybara-service bot pushed a commit that referenced this pull request Jan 7, 2026
@ashiqimranintel @Google-ML-Automation
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
328bf74 
…ntel GPU

Imported from GitHub PR #35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a2 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd
PiperOrigin-RevId: 853258690
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 7, 2026
@ashiqimranintel @tensorflower-gardener
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
616d5eb 
…ntel GPU

Imported from GitHub PR openxla/xla#35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a21e9e59c38e961ccd68b036a2c52403728 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1abcd5b84fc503fdc6a2502adeebf813d4 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd19d4e6ba9d521003b4f047e687feffd3d by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd19d4e6ba9d521003b4f047e687feffd3d
PiperOrigin-RevId: 853258690
copybara-service bot pushed a commit that referenced this pull request Jan 7, 2026
@ashiqimranintel @Google-ML-Automation
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
8704469 
…ntel GPU

Imported from GitHub PR #35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a2 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd
PiperOrigin-RevId: 853258690
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 7, 2026
@ashiqimranintel @tensorflower-gardener
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
1747f1c 
…ntel GPU

Imported from GitHub PR openxla/xla#35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a21e9e59c38e961ccd68b036a2c52403728 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1abcd5b84fc503fdc6a2502adeebf813d4 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd19d4e6ba9d521003b4f047e687feffd3d by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd19d4e6ba9d521003b4f047e687feffd3d
PiperOrigin-RevId: 853258690
copybara-service bot pushed a commit that referenced this pull request Jan 7, 2026
@ashiqimranintel @Google-ML-Automation
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
74c5bbf 
…ntel GPU

Imported from GitHub PR #35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a2 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd
PiperOrigin-RevId: 853258690
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 7, 2026
@ashiqimranintel @tensorflower-gardener
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
a5fcb03 
…ntel GPU

Imported from GitHub PR openxla/xla#35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a21e9e59c38e961ccd68b036a2c52403728 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1abcd5b84fc503fdc6a2502adeebf813d4 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd19d4e6ba9d521003b4f047e687feffd3d by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

Reverts 989c58d

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd19d4e6ba9d521003b4f047e687feffd3d
PiperOrigin-RevId: 853258690
copybara-service bot pushed a commit that referenced this pull request Jan 8, 2026
@ashiqimranintel @Google-ML-Automation
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
14e53e9 
…ntel GPU

Imported from GitHub PR #35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a2 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd
PiperOrigin-RevId: 853719463
@copybara-service copybara-service bot mentioned this pull request Jan 8, 2026
Open
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 8, 2026
@ashiqimranintel @tensorflower-gardener
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
bdbfa19 
…ntel GPU

Imported from GitHub PR openxla/xla#35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a21e9e59c38e961ccd68b036a2c52403728 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1abcd5b84fc503fdc6a2502adeebf813d4 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd19d4e6ba9d521003b4f047e687feffd3d by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd19d4e6ba9d521003b4f047e687feffd3d
PiperOrigin-RevId: 853719463
@copybara-service copybara-service bot mentioned this pull request Jan 8, 2026
Draft
@ashiqimranintel
Copy link
Contributor Author

ashiqimranintel commented Jan 8, 2026

@beckerhe , added a commit that is to fix the JAX failures and also that the bazel query failure is address by the tools PR that has been merged google-ml-infra/rules_ml_toolchain#168

copybara-service bot pushed a commit that referenced this pull request Jan 9, 2026
@ashiqimranintel @Google-ML-Automation
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
6bfa7be 
…ntel GPU

Imported from GitHub PR #35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a2 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd
PiperOrigin-RevId: 853719463
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 9, 2026
@ashiqimranintel @tensorflower-gardener
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
59defd2 
…ntel GPU

Imported from GitHub PR openxla/xla#35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a21e9e59c38e961ccd68b036a2c52403728 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1abcd5b84fc503fdc6a2502adeebf813d4 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd19d4e6ba9d521003b4f047e687feffd3d by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd19d4e6ba9d521003b4f047e687feffd3d
PiperOrigin-RevId: 853719463
copybara-service bot pushed a commit that referenced this pull request Jan 13, 2026
@ashiqimranintel @Google-ML-Automation
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
be8fc6f 
…ntel GPU

Imported from GitHub PR #35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a2 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd
PiperOrigin-RevId: 853719463
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 13, 2026
@ashiqimranintel @tensorflower-gardener
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
2f5411f 
…ntel GPU

Imported from GitHub PR openxla/xla#35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a21e9e59c38e961ccd68b036a2c52403728 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1abcd5b84fc503fdc6a2502adeebf813d4 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd19d4e6ba9d521003b4f047e687feffd3d by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd19d4e6ba9d521003b4f047e687feffd3d
PiperOrigin-RevId: 853719463
@penpornk
Copy link
Member

penpornk commented Jan 13, 2026

@ashiqimranintel Could you please help take a look at the CI failures?

copybara-service bot pushed a commit that referenced this pull request Jan 13, 2026
@ashiqimranintel @Google-ML-Automation
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
0fd3a00 
…ntel GPU

Imported from GitHub PR #35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a2 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd
PiperOrigin-RevId: 853719463
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 13, 2026
@ashiqimranintel @tensorflower-gardener
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
f772172 
…ntel GPU

Imported from GitHub PR openxla/xla#35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a21e9e59c38e961ccd68b036a2c52403728 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1abcd5b84fc503fdc6a2502adeebf813d4 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd19d4e6ba9d521003b4f047e687feffd3d by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

Reverts bbea049

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd19d4e6ba9d521003b4f047e687feffd3d
PiperOrigin-RevId: 853719463
@ashiqimranintel
Copy link
Contributor Author

ashiqimranintel commented Jan 13, 2026

@penpornk , the failures are unrelated to this PR.

@ashiqimranintel
Copy link
Contributor Author

ashiqimranintel commented Jan 14, 2026

@penpornk can you check again?

@ashiqimranintel
Copy link
Contributor Author

ashiqimranintel commented Jan 15, 2026

@penpornk , I resolved the conflict, can you check again?

@penpornk penpornk added the kokoro:force-run Forces CI to rerun label Jan 19, 2026
@penpornk
Copy link
Member

penpornk commented Jan 19, 2026

Sorry for the delay. Rerunning the tests now.

@ashiqimranintel
Copy link
Contributor Author

ashiqimranintel commented Jan 22, 2026

@penpornk , the errors are unrelated to my PR, can you check again?

copybara-service bot pushed a commit that referenced this pull request Jan 26, 2026
@ashiqimranintel @Google-ML-Automation
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
322a023 
…ntel GPU

Imported from GitHub PR #35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a2 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd
PiperOrigin-RevId: 853719463
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 26, 2026
@ashiqimranintel @tensorflower-gardener
PR #35304: [XLA:GPU] [plugin] Adding sycl/oneapi plugin support for I…
419966f 
…ntel GPU

Imported from GitHub PR openxla/xla#35304

This PR will enable sycl/oneapi plugin support for Intel GPU
Copybara import of the project:

--
cca65a21e9e59c38e961ccd68b036a2c52403728 by Ashiq Imran <ashiq.imran@intel.com>:

Adding sycl/oneapi plugin support

--
a0a9db1abcd5b84fc503fdc6a2502adeebf813d4 by Ashiq Imran <ashiq.imran@intel.com>:

addressing review comments

--
8d2f1dd19d4e6ba9d521003b4f047e687feffd3d by ag.ramesh <ag.ramesh@intel.com>:

Added if_cuda_is_configured check that was removed and reverted incorrect change.

Merging this change closes #35304

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#35304 from Intel-tensorflow:aimran/oneapi_plugin 8d2f1dd19d4e6ba9d521003b4f047e687feffd3d
PiperOrigin-RevId: 853719463
@ashiqimranintel
Copy link
Contributor Author

ashiqimranintel commented Jan 26, 2026

@penpornk , @beckerhe , I resolved merge conflict, can you check it again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@penpornk penpornk Awaiting requested review from penpornk

@beckerhe beckerhe Awaiting requested review from beckerhe

Assignees

No one assigned

Labels

kokoro:force-run Forces CI to rerun

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashiqimranintel @penpornk @beckerhe @agramesh1