Add MergeNamedShardingIfCompatible to hlo_sharding_util.#38137
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Add MergeNamedShardingIfCompatible to hlo_sharding_util.#38137copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
This change introduces a utility function to merge two NamedSharding instances if they are compatible. The merging logic aims to find the most specific sharding for each dimension by taking the longer axis sequence if one is a prefix of the other, while ensuring no conflicts with axes used in other dimensions. The existing MergeShardingIfCompatible is updated to use this new function when both shardings are NamedShardings. New test cases are added to validate the NamedSharding merge behavior. PiperOrigin-RevId: 872820304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MergeNamedShardingIfCompatible to hlo_sharding_util.
This change introduces a utility function to merge two NamedSharding instances if they are compatible. The merging logic aims to find the most specific sharding for each dimension by taking the longer axis sequence if one is a prefix of the other, while ensuring no conflicts with axes used in other dimensions. The existing MergeShardingIfCompatible is updated to use this new function when both shardings are NamedShardings. New test cases are added to validate the NamedSharding merge behavior.