PR #38135: [xla:pjrt] Unify AsyncWorkRunner API with tsl::Executor#38155
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
PR #38135: [xla:pjrt] Unify AsyncWorkRunner API with tsl::Executor#38155copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_873879190
branch
3 times, most recently
from
bcd8855 to
ad78d12
Compare
Imported from GitHub PR #38135 We already have `tsl::Executor` that solves the same problem in many other APIs, migrate PJRT to standard API with a path for further cleanup. 1. `AsyncWorkRunner` is a `tsl::Executor` 2. Implement `ExecuteWhenReady` once because all implementations use the same `RunWhenReady` Copybara import of the project: -- 8e87762 by Eugene Zhulenev <ezhulenev@openxla.org>: [xla:pjrt] Unify AsyncWorkRunner API with tsl::Executor Merging this change closes #38135 FUTURE_COPYBARA_INTEGRATE_REVIEW=#38135 from ezhulenev:async-work-runner-0 8e87762 PiperOrigin-RevId: 873879190
copybara-service
bot
force-pushed
the
test_873879190
branch
from
ad78d12 to
71d826a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #38135: [xla:pjrt] Unify AsyncWorkRunner API with tsl::Executor
Imported from GitHub PR #38135
We already have
tsl::Executorthat solves the same problem in many other APIs, migrate PJRT to standard API with a path for further cleanup.AsyncWorkRunneris atsl::ExecutorExecuteWhenReadyonce because all implementations use the sameRunWhenReadyCopybara import of the project:
--
8e87762 by Eugene Zhulenev ezhulenev@openxla.org:
[xla:pjrt] Unify AsyncWorkRunner API with tsl::Executor
Merging this change closes #38135
FUTURE_COPYBARA_INTEGRATE_REVIEW=#38135 from ezhulenev:async-work-runner-0 8e87762