PR #38107: [xla:gpu] Use default memory space for output in collective_ops_ffi_test#38186
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
PR #38107: [xla:gpu] Use default memory space for output in collective_ops_ffi_test#38186copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
…e_ops_ffi_test Imported from GitHub PR #38107 We should not be returning results in collective memory space to users, they should always be returned in default device memory space. Copybara import of the project: -- 4356cd4 by Eugene Zhulenev <ezhulenev@openxla.org>: [xla:gpu] Use default memory space for output in collective_ops_ffi_test.cc We should not be returning results in collective memory space to users, they should always be returned in default device memory space. Merging this change closes #38107 FUTURE_COPYBARA_INTEGRATE_REVIEW=#38107 from ezhulenev:patch-7 4356cd4 PiperOrigin-RevId: 874228221
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #38107: [xla:gpu] Use default memory space for output in collective_ops_ffi_test
Imported from GitHub PR #38107
We should not be returning results in collective memory space to users, they should always be returned in default device memory space.
Copybara import of the project:
--
4356cd4 by Eugene Zhulenev ezhulenev@openxla.org:
[xla:gpu] Use default memory space for output in collective_ops_ffi_test.cc
We should not be returning results in collective memory space to users, they should always be returned in default device memory space.
Merging this change closes #38107
FUTURE_COPYBARA_INTEGRATE_REVIEW=#38107 from ezhulenev:patch-7 4356cd4