PR #37903: [xla:gpu] Use Command::Walk APIs to collect buffer uses and command properties#38187
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
PR #37903: [xla:gpu] Use Command::Walk APIs to collect buffer uses and command properties#38187copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
ff399f8 to
20126f5
Compare
…d command properties Imported from GitHub PR #37903 In preparation for `Command` and `Thunk` unification make sure that `buffer_uses` has the same semantics, and use command walking API to collect buffer and resource uses for all nested commands. Copybara import of the project: -- de2b073 by Eugene Zhulenev <ezhulenev@openxla.org>: [xla:gpu] Use Command::Walk APIs to collect buffer uses and command properties Merging this change closes #37903 FUTURE_COPYBARA_INTEGRATE_REVIEW=#37903 from ezhulenev:command-walking-0 de2b073 PiperOrigin-RevId: 874228029
20126f5 to
75960a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #37903: [xla:gpu] Use Command::Walk APIs to collect buffer uses and command properties
Imported from GitHub PR #37903
In preparation for
CommandandThunkunification make sure thatbuffer_useshas the same semantics, and use command walking API to collect buffer and resource uses for all nested commands.Copybara import of the project:
--
de2b073 by Eugene Zhulenev ezhulenev@openxla.org:
[xla:gpu] Use Command::Walk APIs to collect buffer uses and command properties
Merging this change closes #37903
FUTURE_COPYBARA_INTEGRATE_REVIEW=#37903 from ezhulenev:command-walking-0 de2b073