Skip to content

Make SpmdPartitioningVisitor::HandleCustomCall_XYZ public -> private. #38188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −6
Open

Make SpmdPartitioningVisitor::HandleCustomCall_XYZ public -> private. #38188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions xla/service/spmd/spmd_partitioner.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -746,12 +746,6 @@ class SpmdPartitioningVisitor : public DfsHloVisitorWithDefault {
// Common handle for HLOs that runs on a single device.
absl::Status HandleSingleDevice(const HloInstruction* hlo);

// CustomCall handlers per call target.
absl::Status HandleCustomCallTopK(HloInstruction* hlo);
// Convenient custom ops defined by the partitioner itself.
absl::Status HandleCustomCallSPMDInternal_RotateRight(HloInstruction* hlo);
absl::Status HandleCustomCallSPMDInternal_MultiRotate(HloInstruction* hlo);

virtual std::unique_ptr<SpmdPartitioningVisitor> Clone() const;

// Returns the PartitionedHlo that corresponds to the original hlo.
Expand Down Expand Up @@ -906,6 +900,13 @@ class SpmdPartitioningVisitor : public DfsHloVisitorWithDefault {
absl::Status HandleDUSAllPartitionedSliceDimsHaveConstantIndices(
HloInstruction* hlo, const HloInstruction* input_tensor,
const HloInstruction* update_tensor);

// Handlers for specific custom call targets.
// go/keep-sorted start
absl::Status HandleCustomCallSPMDInternal_MultiRotate(HloInstruction* hlo);
absl::Status HandleCustomCallSPMDInternal_RotateRight(HloInstruction* hlo);
absl::Status HandleCustomCallTopK(HloInstruction* hlo);
// go/keep-sorted end
};

} // namespace spmd
Expand Down
Loading