Skip to content

Enable perf_counters tool for GPU profiles #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cashton-nvidia wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −3
Open

Enable perf_counters tool for GPU profiles #2480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions xprof/convert/xplane_to_tool_names.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,18 @@ absl::StatusOr<std::string> GetAvailableToolNames(
has_dcn_collective_stats =
has_dcn_collective_stats || HasDcnCollectiveStatsInXSpace(*xspace);

std::vector<const XPlane*> tpu_planes = tsl::profiler::FindPlanesWithPrefix(
*xspace, tsl::profiler::kTpuPlanePrefix);
for (const XPlane* plane : tpu_planes) {
// Check both TPU and GPU planes for perf counter data.
std::vector<const XPlane*> device_planes =
tsl::profiler::FindPlanesWithPrefix(*xspace,
tsl::profiler::kTpuPlanePrefix);
{
std::vector<const XPlane*> gpu_planes =
tsl::profiler::FindPlanesWithPrefix(*xspace,
tsl::profiler::kGpuPlanePrefix);
device_planes.insert(device_planes.end(), gpu_planes.begin(),
gpu_planes.end());
}
for (const XPlane* plane : device_planes) {
tsl::profiler::XPlaneVisitor visitor =
tsl::profiler::CreateTfXPlaneVisitor(plane);
visitor.ForEachLine([&](const tsl::profiler::XLineVisitor& line) {
Expand Down