Skip to content

Conversation

@will4j
Copy link
Contributor

@will4j will4j commented Dec 31, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

As --nodepool-name becomes a Required arguments, executing cmd yurtadm join --nodepool-name=xxx will failed with error msg when --nodepool-name is specified, the specified nodePool should be exist., but the actual cause is nodepools.apps.openyurt.io "xxx" is forbidden: User "system:bootstrap:xxxxx" cannot get resource "nodepools" in API group "apps.openyurt.io" at the cluster scope.

This pr:

  1. displays err of GetNodePoolInfoWithRetry
  2. add get permission of nodepools to clusterrole yurt-hub-yurt-static-set-role which binding to serviceaccount groupsystem:bootstrappers

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@will4j will4j requested a review from a team as a code owner December 31, 2025 15:26
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.89%. Comparing base (0d84778) to head (8bff350).

Files with missing lines Patch % Lines
pkg/yurtadm/cmd/join/join.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2490   +/-   ##
=======================================
  Coverage   43.89%   43.89%           
=======================================
  Files         399      399           
  Lines       26560    26563    +3     
=======================================
+ Hits        11659    11661    +2     
- Misses      13841    13843    +2     
+ Partials     1060     1059    -1     
Flag Coverage Δ
unittests 43.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant