Debian: drop REMAKE_INITRD from the Bookworm and Trixie guides - #643
Merged
Conversation
The line was added in 417c2a5 for Buster, where dkms 2.6 really did rebuild the initrd itself: read_conf turned REMAKE_INITRD=yes into remake_initrd, and do_install then called make_initrd, which on Debian ran update-initramfs. Without it a kernel upgrade regenerated the initrd before the module had been built against the new kernel, and the system did not come back up. dkms 3.0 deprecated the variable (dkms-project/dkms#164) and took the initrd code out with it. All that is left of it is one line that prints "Deprecated feature: REMAKE_INITRD" and returns; nothing in dkms 3.x touches an initramfs at all. Bookworm ships 3.0.10 and Trixie ships 3.2.2, so on both the file we tell the reader to write buys them a warning on every dkms run and nothing else. The ordering it was there to fix is now handled by the kernel hook dkms installs: run-parts walks /etc/kernel/postinst.d in name order, so dkms builds the module before initramfs-tools regenerates the initrd. Bullseye and Buster keep the line: they ship dkms 2.8.4 and 2.6.1, where it still does its job. Closes: #534 Signed-off-by: George Melikov <mail@gmelikov.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line was added in 417c2a5 for Buster, where dkms 2.6 really did rebuild the initrd itself: read_conf turned REMAKE_INITRD=yes into remake_initrd, and do_install then called make_initrd, which on Debian ran update-initramfs. Without it a kernel upgrade regenerated the initrd before the module had been built against the new kernel, and the system did not come back up.
dkms 3.0 deprecated the variable (dkms-project/dkms#164) and took the initrd code out with it. All that is left of it is one line that prints "Deprecated feature: REMAKE_INITRD" and returns; nothing in dkms 3.x touches an initramfs at all. Bookworm ships 3.0.10 and Trixie ships 3.2.2, so on both the file we tell the reader to write buys them a warning on every dkms run and nothing else.
The ordering it was there to fix is now handled by the kernel hook dkms installs: run-parts walks /etc/kernel/postinst.d in name order, so dkms builds the module before initramfs-tools regenerates the initrd.
Bullseye and Buster keep the line: they ship dkms 2.8.4 and 2.6.1, where it still does its job.
Closes: #534