This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Actually enable CONFIG_ZFS in builds.#228
Merged
behlendorf merged 1 commit intoopenzfs:masterfrom May 25, 2021
Merged
Conversation
It turns out that "make proper" drops the 'CONFIG_ZFS=y' line from .config. I couldn't readily find any documentation about why that would be so, so I just added it later. Closes: openzfs#227 Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Contributor
Author
|
As an example illustrating the problem this is intended to solve, openzfs/zfs#12110 broke every test and buildbot...except this one. |
behlendorf
approved these changes
May 25, 2021
Contributor
behlendorf
left a comment
behlendorf
left a comment
There was a problem hiding this comment.
Interesting, I'm fairly certain CONFIG_ZFS used to be preserved. Perhaps something changed in the kernel build system and we failed to notice. Either way, thanks for noticing and fix this. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that "make proper" drops the 'CONFIG_ZFS=y' line from
.config. I couldn't readily find any documentation about why that
would be so, so I just added it later.
Tested by: Just iterating on it on my testbed until it actually worked.
Closes: #227
Signed-off-by: Rich Ercolani rincebrain@gmail.com