Skip to content

libunicode: merge into libzpool#18071

Closed
robn wants to merge 2 commits intoopenzfs:masterfrom
robn:libunicode-delete
Closed

libunicode: merge into libzpool#18071
robn wants to merge 2 commits intoopenzfs:masterfrom
robn:libunicode-delete

Conversation

@robn
Copy link
Member

@robn robn commented Dec 19, 2025 •
edited
Loading

Motivation and Context

Tiny cleanup of opportunity.

Description

Just build u8_textprep.c directly into libzpool, since nothing else uses it.

And then, since it's always built into the zfs "module" in all situations, move it to module/zfs.

How Has This Been Tested?

Compile checked on Linux & FreeBSD.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@robn
Copy link
Member Author

robn commented Dec 19, 2025

@behlendorf you might recall you suggested that libunicode, libzstd and libicp all get this treatment. The other two aren't this simple mostly because they haven't different compile flags which automake doesn't really provide a good mechanism for outside of utility libraries. I'm intending to look into them further once I finish up the "easy" cleanup (like this one) and get symbol visibility where I want them.

behlendorf
behlendorf reviewed Dec 19, 2025
View reviewed changes
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Dec 19, 2025
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 20, 2025
robn added 2 commits December 20, 2025 16:07
@robn
libunicode: merge into libzpool
e92fcf5 
It's a single source file that is not used anywhere else, so there's no
reason to keep it separate.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
@robn
u8_textprep: move into module/zfs
17e1a16 
Now that it's built into the main zfs module in all cases, there's no
reason to put it in its own dir.

Sponsored-by: https://despairlabs.com/sponsor/
Signed-off-by: Rob Norris <robn@despairlabs.com>
@robn robn force-pushed the libunicode-delete branch from 0ff33bc to 17e1a16 Compare December 20, 2025 05:08
@github-actions github-actions bot removed the Status: Accepted Ready to integrate (reviewed, tested) label Dec 20, 2025
@robn
Copy link
Member Author

robn commented Dec 21, 2025

Just rebased to sort out the conflict in the comment in lib/Makefile.am. No other changes.

@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Dec 22, 2025
@lundman
Copy link
Contributor

lundman commented Dec 22, 2025

I am a bit torn on these PRs, I get the attraction of cleaning up code, and you are doing the heavy lifting, but it also means I have to go that work you just did, twice.. just for cleanups. Ah well, it is the situation I find myself in

@behlendorf
Copy link
Contributor

behlendorf commented Dec 22, 2025

@lundman thanks for chiming in, and sorry about all the churn and making work for you! I think this kind of cleanup is worthwhile, and will pay dividends in the longer term. If possible, I'm hoping we can use this next 2.5 release cycle to tackle most of this cleanup and restructuring.

behlendorf pushed a commit that referenced this pull request Dec 22, 2025
@robn @behlendorf
u8_textprep: move into module/zfs
654e762 
Now that it's built into the main zfs module in all cases, there's no
reason to put it in its own dir.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes #18071
@robn robn deleted the libunicode-delete branch January 9, 2026 02:37
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 31, 2026
@robn @mcmilk
libunicode: merge into libzpool
3a34f72 
It's a single source file that is not used anywhere else, so there's no
reason to keep it separate.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18071
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 31, 2026
@robn @mcmilk
u8_textprep: move into module/zfs
f56a544 
Now that it's built into the main zfs module in all cases, there's no
reason to put it in its own dir.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18071
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Feb 5, 2026
@robn @lundman
libunicode: merge into libzpool
3ec5f80 
It's a single source file that is not used anywhere else, so there's no
reason to keep it separate.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18071
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Feb 5, 2026
@robn @lundman
u8_textprep: move into module/zfs
8ede468 
Now that it's built into the main zfs module in all cases, there's no
reason to put it in its own dir.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18071
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@robn @lundman
libunicode: merge into libzpool
7d4d572 
It's a single source file that is not used anywhere else, so there's no
reason to keep it separate.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18071
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@robn @lundman
u8_textprep: move into module/zfs
4d7f876 
Now that it's built into the main zfs module in all cases, there's no
reason to put it in its own dir.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18071
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@robn @lundman
libunicode: merge into libzpool
e393141 
It's a single source file that is not used anywhere else, so there's no
reason to keep it separate.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18071
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
@robn @lundman
u8_textprep: move into module/zfs
782379a 
Now that it's built into the main zfs module in all cases, there's no
reason to put it in its own dir.

Sponsored-by: https://despairlabs.com/sponsor/
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <robn@despairlabs.com>
Closes openzfs#18071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

No one assigned

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@robn @lundman @behlendorf @amotin