Skip to content

cmd/zfs: clone: accept -u to not mount newly created datasets#18080

Merged
amotin merged 3 commits intoopenzfs:masterfrom
intelfx:work/zfs-clone-nomount
Jan 5, 2026
Merged

cmd/zfs: clone: accept -u to not mount newly created datasets#18080
amotin merged 3 commits intoopenzfs:masterfrom
intelfx:work/zfs-clone-nomount

Conversation

@intelfx
Copy link
Contributor

@intelfx intelfx commented Dec 21, 2025

Motivation and Context

Description

Add a zfs clone -u flag, bringing it in line with all other subcommands that may create datasets.

How Has This Been Tested?

  • compile-tested
  • run-tested on x86_64 Linux
  • ZTS tests added

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@intelfx intelfx force-pushed the work/zfs-clone-nomount branch from c75cb57 to 6b01016 Compare December 21, 2025 17:22
@intelfx intelfx changed the title zfs clone: accept -u to not mount newly created datasets cmd/zfs: clone: accept -u to not mount newly created datasets Dec 21, 2025
@intelfx intelfx force-pushed the work/zfs-clone-nomount branch from 6b01016 to ea1b2ac Compare December 21, 2025 17:33
@intelfx intelfx marked this pull request as draft December 21, 2025 17:40
@intelfx intelfx marked this pull request as ready for review December 21, 2025 17:40
@github-actions github-actions bot added Status: Work in Progress Not yet ready for general review Status: Code Review Needed Ready for review and testing and removed Status: Work in Progress Not yet ready for general review labels Dec 21, 2025
@intelfx intelfx force-pushed the work/zfs-clone-nomount branch from ea1b2ac to 61d80b0 Compare December 23, 2025 20:34
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
@intelfx intelfx force-pushed the work/zfs-clone-nomount branch from 61d80b0 to f5a374c Compare December 23, 2025 20:35
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
@intelfx intelfx force-pushed the work/zfs-clone-nomount branch from f5a374c to 829146f Compare December 23, 2025 20:59
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 24, 2025
@amotin amotin merged commit dbb3f24 into openzfs:master Jan 5, 2026
26 checks passed
amotin pushed a commit to amotin/zfs that referenced this pull request Jan 29, 2026
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#18080
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 31, 2026
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#18080
amotin pushed a commit to amotin/zfs that referenced this pull request Feb 3, 2026
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#18080
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Feb 5, 2026
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#18080
tonyhutter pushed a commit that referenced this pull request Feb 5, 2026
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes #18080
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#18080
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
Signed-off-by: Ivan Shapovalov <intelfx@intelfx.name>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Closes openzfs#18080
@intelfx intelfx deleted the work/zfs-clone-nomount branch February 28, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants