Skip to content

FreeBSD: unbreak compilation on i386#18096

Merged
behlendorf merged 1 commit intoopenzfs:masterfrom
mmatuska:pr/18096
Jan 15, 2026
Merged

FreeBSD: unbreak compilation on i386#18096
behlendorf merged 1 commit intoopenzfs:masterfrom
mmatuska:pr/18096

Conversation

@mmatuska
Copy link
Contributor

Motivation and Context

The compilation on FreeBSD i386 is broken.

Description

Incorrect printf specifier in mmap_seek.c
Missing cast to atomic_add_64

How Has This Been Tested?

Compilation on FreeBSD i386 and amd64

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier
module/zfs/vdev.c: vdev_clear(): correctly cast argument to atomic_add_64()

Signed-off-by: Martin Matuska <mm@FreeBSD.org>
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Jan 2, 2026
@mmatuska mmatuska requested a review from amotin January 3, 2026 22:23
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Jan 5, 2026
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 15, 2026
@behlendorf behlendorf merged commit 8605bdf into openzfs:master Jan 15, 2026
55 of 58 checks passed
@behlendorf
Copy link
Contributor

behlendorf commented Jan 15, 2026

commitstyle warning in the commit messages fixed when merging.

amotin pushed a commit to amotin/zfs that referenced this pull request Jan 29, 2026
tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier
module/zfs/vdev.c: vdev_clear(): correctly cast argument to
atomic_add_64().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#18096
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 31, 2026
tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier
module/zfs/vdev.c: vdev_clear(): correctly cast argument to
atomic_add_64().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#18096
amotin pushed a commit to amotin/zfs that referenced this pull request Feb 3, 2026
tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier
module/zfs/vdev.c: vdev_clear(): correctly cast argument to
atomic_add_64().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#18096
amotin pushed a commit to amotin/zfs that referenced this pull request Feb 3, 2026
tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier
module/zfs/vdev.c: vdev_clear(): correctly cast argument to
atomic_add_64().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#18096
lundman pushed a commit to openzfsonosx/openzfs-fork that referenced this pull request Feb 5, 2026
tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier
module/zfs/vdev.c: vdev_clear(): correctly cast argument to
atomic_add_64().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#18096
tonyhutter pushed a commit that referenced this pull request Feb 5, 2026
tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier
module/zfs/vdev.c: vdev_clear(): correctly cast argument to
atomic_add_64().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes #18096
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier
module/zfs/vdev.c: vdev_clear(): correctly cast argument to
atomic_add_64().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#18096
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Feb 23, 2026
tests/zfs-tests/cmd/mmap_seek.c: use correct printf specifier
module/zfs/vdev.c: vdev_clear(): correctly cast argument to
atomic_add_64().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Martin Matuska <mm@FreeBSD.org>
Closes openzfs#18096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants