zcp: implement zfs.get_prop() for bookmarks #18121
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch is still pretty rough, but i have so many questions to ask! see comments marked
XXX:)Motivation and Context
bookmarks support a small set of dataset properties that either reflect the snapshot they were based on (
guid,createtxg,creation,ivsetguid) or are unique to the redaction bookmark (redact_snaps,redact_complete).zfs get <property>can query bookmark properties, butzfs.get_prop()is unable to query bookmark properties (#17949), because doing so for bookmarks requires a different procedure to other datasets.Description
this patch fixes #17949 by adding a separate code path for bookmarks in zcp_get_prop(), which effectively calls dsl_bookmark_fetch_props() instead of whatever we do for other datasets.
How Has This Been Tested?
(TODO: see issue comments)
Types of changes
Checklist:
Signed-off-by.