Fix --enable-invariants on FreeBSD#18131
Merged
behlendorf merged 1 commit intoopenzfs:masterfrom Jan 14, 2026
Merged
Conversation
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make. Signed-off-by: Alan Somers <asomers@gmail.com>
behlendorf
force-pushed
the
WITH_DEBUG
branch
from
2044056 to
dd73b30
Compare
behlendorf
added
Type: Building
behlendorf
approved these changes
Jan 13, 2026
Contributor
behlendorf
left a comment
behlendorf
left a comment
There was a problem hiding this comment.
I'm not that familiar with the FreeBSD build system but this seems pretty reasonable.
behlendorf
added
Status: Accepted
14 tasks
amotin
pushed a commit
to amotin/zfs
that referenced
this pull request
Jan 29, 2026
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes openzfs#18131
mcmilk
pushed a commit
to mcmilk/zfs
that referenced
this pull request
Jan 31, 2026
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes openzfs#18131
amotin
pushed a commit
to amotin/zfs
that referenced
this pull request
Feb 3, 2026
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes openzfs#18131
amotin
pushed a commit
to amotin/zfs
that referenced
this pull request
Feb 3, 2026
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes openzfs#18131
lundman
pushed a commit
to openzfsonosx/openzfs-fork
that referenced
this pull request
Feb 5, 2026
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes openzfs#18131
tonyhutter
pushed a commit
that referenced
this pull request
Feb 5, 2026
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes #18131
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Feb 23, 2026
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes openzfs#18131
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Feb 23, 2026
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alan Somers <asomers@gmail.com> Closes openzfs#18131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The make symbols were never getting forwarded to the correct make subprocess. As far as I can tell, this has never worked. Either that, or something has changed in the behavior of make.
Motivation and Context
The
--enable-invariantsconfigure option had no effect on FreeBSD.ASSERTstatements in the kernel module were being ignored.Description
Pass the
WITH_DEBUGandWITH_INVARIANTSvariables to the make subprocess that builds the kernel.How Has This Been Tested?
cccommand line used to compile kernel sourcesASSERT(false)into the kernel code, and verifying that it causes a panic at runtime.Types of changes
Checklist:
Signed-off-by.