Skip to content

Make sure we can still write data to txg when flushing RRD#18139

Merged
amotin merged 1 commit intoopenzfs:masterfrom
oshogbo:oshogbo/rrd_panic
Jan 27, 2026
Merged

Make sure we can still write data to txg when flushing RRD#18139
amotin merged 1 commit intoopenzfs:masterfrom
oshogbo:oshogbo/rrd_panic

Conversation

@oshogbo
Copy link
Contributor

@oshogbo oshogbo commented Jan 16, 2026 •
edited
Loading

Motivation and Context

Fix #18112.

Description

The final txgs are used only to clear out any remaining deferred frees, and we cannot write new data to them. Make sure we do not try to do so.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@oshogbo oshogbo changed the title Make sure we can still write data to txg Make sure we can still write data to txg when flushing RRD Jan 16, 2026
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Jan 16, 2026
@oshogbo
Make sure we can still write data to txg
46095ae 
The final txgs are used only to clear out any remaining deferred
frees, and we cannot write new data to them. Make sure we do not
try to do so.

Signed-off-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
@amotin amotin added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jan 23, 2026
@amotin amotin merged commit a157ef6 into openzfs:master Jan 27, 2026
26 checks passed
amotin pushed a commit to amotin/zfs that referenced this pull request Jan 29, 2026
@oshogbo @amotin
Make sure we can still write data to txg
608e5a5 
The final txgs are used only to clear out any remaining deferred
frees, and we cannot write new data to them. Make sure we do not
try to do so.

Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Signed-off-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Closes openzfs#18139
oshogbo added a commit to KlaraSystems/zfs that referenced this pull request Jan 30, 2026
@oshogbo
Make sure we can still write data to txg
e993d09 
The final txgs are used only to clear out any remaining deferred
frees, and we cannot write new data to them. Make sure we do not
try to do so.

Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Signed-off-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Closes openzfs#18139
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 31, 2026
@oshogbo @mcmilk
Make sure we can still write data to txg
9176b4c 
The final txgs are used only to clear out any remaining deferred
frees, and we cannot write new data to them. Make sure we do not
try to do so.

Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Signed-off-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Closes openzfs#18139
mcmilk pushed a commit to mcmilk/zfs that referenced this pull request Jan 31, 2026
@oshogbo @mcmilk
Make sure we can still write data to txg
7d31e87 
The final txgs are used only to clear out any remaining deferred
frees, and we cannot write new data to them. Make sure we do not
try to do so.

Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Signed-off-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Closes openzfs#18139
amotin pushed a commit to amotin/zfs that referenced this pull request Feb 3, 2026
@oshogbo @amotin
Make sure we can still write data to txg
fb57ae7 
The final txgs are used only to clear out any remaining deferred
frees, and we cannot write new data to them. Make sure we do not
try to do so.

Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Signed-off-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Closes openzfs#18139
amotin pushed a commit to amotin/zfs that referenced this pull request Feb 3, 2026
@oshogbo @amotin
Make sure we can still write data to txg
7fb7002 
The final txgs are used only to clear out any remaining deferred
frees, and we cannot write new data to them. Make sure we do not
try to do so.

Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Signed-off-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Closes openzfs#18139
tonyhutter pushed a commit that referenced this pull request Feb 5, 2026
@oshogbo @tonyhutter
Make sure we can still write data to txg
79c3810 
The final txgs are used only to clear out any remaining deferred
frees, and we cannot write new data to them. Make sure we do not
try to do so.

Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Signed-off-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Closes #18139
pcd1193182 pushed a commit to KlaraSystems/zfs that referenced this pull request Feb 10, 2026
@oshogbo @pcd1193182
Make sure we can still write data to txg
2f417e1 
The final txgs are used only to clear out any remaining deferred
frees, and we cannot write new data to them. Make sure we do not
try to do so.

Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Signed-off-by: Mariusz Zaborski <mariusz.zaborski@klarasystems.com>
Closes openzfs#18139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amotin amotin amotin approved these changes

Assignees

No one assigned

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

panic from spa_sync_time_logger() when txg > spa_final_dirty_txg()

2 participants

@oshogbo @amotin