Skip to content

Fix redundant declaration of dsl_pool_t#18263

Merged
behlendorf merged 1 commit intoopenzfs:masterfrom
akashb-22:redundant_declare
Feb 27, 2026
Merged

Fix redundant declaration of dsl_pool_t#18263
behlendorf merged 1 commit intoopenzfs:masterfrom
akashb-22:redundant_declare

Conversation

@akashb-22
Copy link
Contributor

Motivation and Context

Remove redundant dsl_pool variable and duplicate spa_get_dsl() call in vdev_rebuild_thread.

Description

Code cleanup: noticed dsl_pool_t was declared twice in the same function during code review. Removed the redundant declaration.

How Has This Been Tested?

Just locally tested and verified.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

Remove redundant dsl_pool variable and duplicate spa_get_dsl()
call in vdev_rebuild_thread.

Signed-off-by: Akash B <akash-b@hpe.com>
@amotin amotin added the Status: Accepted Ready to integrate (reviewed, tested) label Feb 26, 2026
@behlendorf behlendorf merged commit f8e5af5 into openzfs:master Feb 27, 2026
35 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Accepted Ready to integrate (reviewed, tested)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants