Skip to content

release range lock after freed in dmu. #18647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tiehexue wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −3
Open

release range lock after freed in dmu. #18647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions module/os/linux/zfs/zfs_znode_os.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1625,9 +1625,13 @@ zfs_free_range(znode_t *zp, uint64_t off, uint64_t len)
error = dmu_free_long_range(zfsvfs->z_os, zp->z_id, off, len);

/*
* Zero partial page cache entries. This must be done under a
* range lock in order to keep the ARC and page cache in sync.
* Once freed in dmu, release the range lock, otherwise,
* there may be dead lock if concurrent
* unlink/fsync/ftruncate/msync happens.
*/
zfs_rangelock_exit(lr);
lr = NULL;

if (zn_has_cached_data(zp, off, off + len - 1)) {
loff_t first_page, last_page, page_len;
loff_t first_page_offset, last_page_offset;
Expand Down Expand Up @@ -1665,7 +1669,6 @@ zfs_free_range(znode_t *zp, uint64_t off, uint64_t len)
page_len);
}
}
zfs_rangelock_exit(lr);

return (error);
}
Expand Down
Loading