Skip to content

documentation too general.#18674

Draft
peturingi wants to merge 1 commit into
openzfs:masterfrom
peturingi:patch-1
Draft

documentation too general.#18674
peturingi wants to merge 1 commit into
openzfs:masterfrom
peturingi:patch-1

Conversation

@peturingi

@peturingi peturingi commented Jun 14, 2026

Copy link
Copy Markdown

Motivation and Context

Hann lá svo vel við höggi.

Description

Early in ZFS(8), a dataset is defined as an umbrella term containing:

  • file system,
  • volume,
  • snapshot, and
  • bookmark.

zfs rename does not work on bookmarks. The general term 'dataset' is ok to use, but only after it has been explicitly restricted.

How Has This Been Tested?

man the man page.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the OpenZFS code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
    - [ ] I have added tests to cover my changes.
    - [ ] I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

zfs rename works on volumes.

Dropped the word 'dataset' as its definition includes bookmarks which can not be renamed.

Signed-off-by: Pétur <petur@ingi.dk>
@peturingi peturingi changed the title zfs rename works on volumes. documentation too general. Jun 14, 2026
@peturingi peturingi marked this pull request as draft June 14, 2026 08:28
@github-actions github-actions Bot added the Status: Work in Progress Not yet ready for general review label Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Work in Progress Not yet ready for general review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant