-
-
Notifications
You must be signed in to change notification settings - Fork 30
Added Sortable headers for Pipeline Table #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1094 +/- ##
==========================================
- Coverage 88.56% 88.17% -0.39%
==========================================
Files 102 102
Lines 5560 5608 +48
==========================================
+ Hits 4924 4945 +21
- Misses 636 663 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fixed import order fixed import order fixed import order fixed import order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
dispatcher/backend/src/routes/requested_tasks/requested_task.py
Outdated
Show resolved
Hide resolved
dispatcher/backend/src/routes/requested_tasks/requested_task.py
Outdated
Show resolved
Hide resolved
…- `asc` , `desc`, and default in which it drop sort_order and sort_field
I've Done the required changes :) |
@end-9214 please fix the CI issues Also I feel like passing all following properties to every component is wrong:
There must be some leaniest way to do it, please investigate. |
Closes #1092
Added Sortable Headers for Pipeline Table. Users can click on the column names of the Pipeline Table and see the sorted entries in
asc
ordesc
order, And the order is being indicated via arrows facing upwards forasc
and downwards fordesc
.I added click handlers to the column headers in the pipeline table with the visual indication of arrows. Also added css styling to make sortable columns look different from the non-sortable.
In backend i extended schema to accept and validate sort parameters like - added
sort_by
field to find which column to sort;sort_order
to find the direction (desc
orasc
).I added
get_sort_field_and_apply_order
to handle sorting at the database level. And updatedtasks
andrequested _tasks
to use this sorting functionality.