Skip to content

Remove outdated BOM warning from dependencyManagement #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codefromthecrypt merged 1 commit into from
Mar 25, 2026
+0 −8
Merged

Remove outdated BOM warning from dependencyManagement #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,14 +156,6 @@
</developer>
</developers>

<dependencyManagement>
<!-- Be careful here, especially to not import BOMs as it causes version confusion.

For example, if you imported Netty's BOM here, end users would also download that BOM. As
Brave is indirectly used, this can be extremely confusing when people are troubleshooting
library version assignments. -->
</dependencyManagement>

<dependencies>
<!-- Only add absolutely required dependencies as compile scope. Adding more can pin versions,
causing problems for end users difficult to unravel. -->
Expand Down
Loading