Migrates zipkin-aws to v2 SDK; add v2 sender/instrumentation#237
Merged
codefromthecrypt merged 2 commits intomasterfrom Mar 26, 2026
Merged
Migrates zipkin-aws to v2 SDK; add v2 sender/instrumentation#237codefromthecrypt merged 2 commits intomasterfrom
codefromthecrypt merged 2 commits intomasterfrom
Conversation
…on/sender modules Ports collectors (SQS, Kinesis), module/, and aws-junit from AWS SDK v1 to v2 in-place, keeping package names. Adds new instrumentation-awssdk-sqs and sender-awssdk-kinesis modules. The module jar exclusively uses v2 SDK with zero com.amazonaws dependencies. Upgrades KCL to 3.4.1 and fixes all CVEs via jackson-bom overrides. Signed-off-by: Adrian Cole <adrian@tetrate.io>
Member
Author
|
fyi I bumped to 2.0.0-SNAPSHOT as the server impl is very different. However, this doesn't remove any 1.x client libs, just fills 2.x alts for ones we were missing |
reta
reviewed
Mar 26, 2026
reta
reviewed
Mar 26, 2026
reta
approved these changes
Mar 26, 2026
Member
Author
|
thanks for the review @reta ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brave/instrumentation-awssdk-sqsmodule (v2 SQS messaging instrumentation)reporter/sender-awssdk-kinesismodule (v2 Kinesis sender)Testing
Build and verify:
Elasticsearch smoke test (no real credentials)
Save as
docker-compose-test-es.yaml:SQS collector smoke test (no real credentials)
Save as
docker-compose-test-sqs.yaml:Server boots, v2 SqsClient loads correctly, expected 403 with fake credentials:
Kinesis collector smoke test (no real credentials)
Save as
docker-compose-test-kinesis.yaml:Server boots, KCL 3.x loads correctly, expected 400 with fake credentials: