Skip to content

Conversation

@shakuzen
Copy link
Member

Added some work to #231

Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
Signed-off-by: Tomáš Mózes <hydrapolic@gmail.com>
@shakuzen shakuzen mentioned this pull request Nov 27, 2024
Bumps the version of the Zipkin Docker Java image and OS used by GH Action runners and applies the same conventions to Dockerfile.

Fixes the trivy intermittent issue; See aquasecurity/trivy#7668
@shakuzen
Copy link
Member Author

I'm not sure what is wrong with the lint check. I've finally got the security check passing by upgrading everything, but unfortunately it causes the collector-pubsub module tests to fail. I am out of time to look into it today, but I was having trouble figuring out where the issue was; it does appear to be caused by bumping the pubsub dependencies, though.

@shakuzen
Copy link
Member Author

shakuzen commented Nov 28, 2024

I think I finally got the underlying exception:

Status{code=CANCELLED, description=Failed to read message., cause=com.google.api.pathtemplate.ValidationException: SubscriptionName.parse: formattedString not in valid format: Parameter "projects/test-project/topics/test-subscription" must be in the form "projects/{project=*}/subscriptions/{subscription=*}"
	at com.google.api.pathtemplate.PathTemplate.validatedMatch(PathTemplate.java:460)
	at com.google.pubsub.v1.SubscriptionName.parse(SubscriptionName.java:78)
	at com.google.cloud.pubsub.v1.PubsubMessageWrapper$Builder.<init>(PubsubMessageWrapper.java:409)
	at com.google.cloud.pubsub.v1.PubsubMessageWrapper.newBuilder(PubsubMessageWrapper.java:82)
	at com.google.cloud.pubsub.v1.MessageDispatcher.processReceivedMessages(MessageDispatcher.java:409)
	at com.google.cloud.pubsub.v1.StreamingSubscriberConnection$StreamingPullResponseObserver.onResponse(StreamingSubscriberConnection.java:257)
	at com.google.cloud.pubsub.v1.StreamingSubscriberConnection$StreamingPullResponseObserver.onResponse(StreamingSubscriberConnection.java:221)
	at com.google.api.gax.tracing.TracedResponseObserver.onResponse(TracedResponseObserver.java:91)
	at com.google.api.gax.grpc.ExceptionResponseObserver.onResponseImpl(ExceptionResponseObserver.java:74)
	at com.google.api.gax.rpc.StateCheckingResponseObserver.onResponse(StateCheckingResponseObserver.java:60)
	at com.google.api.gax.grpc.GrpcDirectStreamController$ResponseObserverAdapter.onMessage(GrpcDirectStreamController.java:133)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1MessagesAvailable.runInternal(ClientCallImpl.java:657)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1MessagesAvailable.runInContext(ClientCallImpl.java:644)
	at io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
	at io.grpc.internal.SerializeReentrantCallsDirectExecutor.execute(SerializeReentrantCallsDirectExecutor.java:49)
	at io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl.messagesAvailable(ClientCallImpl.java:672)
	at io.grpc.internal.ForwardingClientStreamListener.messagesAvailable(ForwardingClientStreamListener.java:39)
	at io.grpc.inprocess.InProcessTransport$InProcessStream$InProcessServerStream.lambda$writeMessage$3(InProcessTransport.java:528)
	at io.grpc.SynchronizationContext.drain(SynchronizationContext.java:94)
	at io.grpc.inprocess.InProcessTransport$InProcessStream$InProcessServerStream.writeMessage(InProcessTransport.java:533)
	at io.grpc.internal.ServerCallImpl.sendMessageInternal(ServerCallImpl.java:168)
	at io.grpc.internal.ServerCallImpl.sendMessage(ServerCallImpl.java:152)
	at io.grpc.stub.ServerCalls$ServerCallStreamObserverImpl.onNext(ServerCalls.java:380)
	at zipkin2.collector.pubsub.StreamingPullStreamObserver.run(StreamingPullStreamObserver.java:62)
	at com.google.common.util.concurrent.AbstractExecutionThreadService$1.lambda$doStart$1(AbstractExecutionThreadService.java:57)
	at com.google.common.util.concurrent.Callables.lambda$threadRenaming$3(Callables.java:105)
	at java.base/java.lang.Thread.run(Thread.java:1583)
}

Which I've traced back to this change googleapis/java-pubsub@db522b6. While I don't think that change should have broke this test, certainly not in the way that it did, it does appear we're using the wrong format for the subscription name in the collector-pubsub test. The build passes once fixing that.

A feature added in the client now validates the subscription name format when dispatching messages as a side effect, even if that feature isn't enabled. Uses a correctly formatted subscription name in the test.
@shakuzen
Copy link
Member Author

It looks like the lint failure is probably this issue: tcort/markdown-link-check#369

@shakuzen
Copy link
Member Author

Nothing has changed in any of the markdown with this PR, so I think we can ignore the lint failure in this case. Merging.

@shakuzen shakuzen merged commit 575e443 into openzipkin:master Nov 28, 2024
3 of 4 checks passed
@shakuzen shakuzen deleted the update-infra branch November 28, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants