zrok2: rename caSecretName → ca_cert_configmap to match volume type and v1 convention#404
Merged
zrok2: rename caSecretName → ca_cert_configmap to match volume type and v1 convention#404
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ziti.caSecretNamewas misnamed — the CA bundle is mounted via aconfigMap:volume in all three templates, not a Secret. The field name also diverged from the zrok v1 chart'sca_cert_configmap.Changes
values.yaml: renamecaSecretName→ca_cert_configmap; fix comments referencing "secret" → "configmap"templates/controller-deployment.yaml,frontend-deployment.yaml,pre-delete-hook.yaml: update.Values.ziti.caSecretName→.Values.ziti.ca_cert_configmapREADME.md/README.md.gotmpl: update--setexample and values table entry💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.