Extract acquire into a standalone module for reuse outside acceptance tests - #975
Open
plorenz wants to merge 2 commits into
Open
Extract acquire into a standalone module for reuse outside acceptance tests#975plorenz wants to merge 2 commits into
plorenz wants to merge 2 commits into
Conversation
… tests - moves the acquire package from acceptance/internal/acquire into a new github.com/openziti/sdk-golang/acquire module with its own go.mod/go.sum - updates the acceptance harness and matrix command to import the new path - adds a require plus in-repo replace for the acquire module to acceptance - relocates the checked-in versions.yaml validation test into the acceptance harness package, locating the file via FindVersionsFile instead of a fixed path - refreshes the package doc to describe the general-purpose, caller-parameterized surface
- adds a WithVersion functional option that stamps common/version Version and Revision via -ldflags when building a git-ref selector from source, so the binary reports a real version instead of the unstamped dev default - derives the version package linker path from the checked-out go.mod, so both the v1 and v2 ziti module lines are handled - keys the build cache and the memoization entry per stamped version, so differing stamps of the same commit do not collide - adds unit tests for the cache-key suffix and ldflags derivation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/openziti/sdk-golang/acquire module with its own go.mod/go.sum
harness package, locating the file via FindVersionsFile instead of a fixed path