add new feature integrated with OIDC compatible#214
Open
jason-webcomm wants to merge 1 commit intoopenziti:mainfrom
Open
add new feature integrated with OIDC compatible#214jason-webcomm wants to merge 1 commit intoopenziti:mainfrom
jason-webcomm wants to merge 1 commit intoopenziti:mainfrom
Conversation
dovholuknf
reviewed
Dec 2, 2023
| req.ziti_idp_issuer_base_url = target.idp_issuer_base_url; | ||
| req.ziti_idp_client_id = target.idp_client_id; | ||
| req.ziti_idp_client_id = target.idp_client_id; | ||
| req.ziti_idp_type = target.idp_type; |
Member
There was a problem hiding this comment.
can you set these dynamically based on the base url and oidc discovery endpoint? there should be a .well-known/openid-configuration url that browzer can use to bootstrap these values. Then all these values can be just "optional" and I don't think you'd need the "idp_type" enum then?
With these changes, you were able to connect to keycloak?
Author
There was a problem hiding this comment.
if we set the url data from oidc discovery endpoint on runtime, i think that will have cors issue and performance issue. so i would like to use the setting on configuration file. I add idp_type that for fallback original setting (Auth0 first).
this pr with pr on ziti-browzer-runtime , i can connect to keycloak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the new ZITI_BROWZER_BOOTSTRAPPER_TARGETS as below
ZITI_BROWZER_BOOTSTRAPPER_TARGETS=' {
"targetArray": [
{
"vhost": "${ZITI_BROWZER_VHOST}",
"service": "${ZITI_BROWZER_SERVICE}",
"path": "/",
"scheme": "http",
"idp_issuer_base_url": "${ZITI_BROWZER_OIDC_URL}",
"idp_client_id": "${ZITI_BROWZER_CLIENT_ID}",
"idp_type": "OIDC",
"idp_authorization_endpoint": "${ZITI_BROWZER_AUTH_ENDPOINT}",
"idp_token_endpoint": "${ZITI_BROWZER_TOKEN_ENDPOINT}",
"idp_userinfo_endpoint": "${ZITI_BROWZER_USERINFO_ENDPOINT}",
"idp_issuer": "${ZITI_BROWZER_ISSUER}",
"idp_jwks_uri": "${ZITI_BROWZER_JWKS_URI}",
"idp_scopes": ["${ZITI_BROWZER_SCOPE}"]
}
]
}'