Skip to content

use registry cache instead of experimental gha cache method #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qrkourier merged 2 commits into from
Apr 7, 2025
Merged

use registry cache instead of experimental gha cache method #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5ba76c
use registry cache instead of experimental gha cache method
qrkourier Apr 7, 2025
b3ad170
fix typo
qrkourier Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ jobs:
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
platforms: linux/amd64,linux/arm64
cache-from: type=gha,scope=${{ github.workflow }}
cache-to: type=gha,mode=max,scope=${{ github.workflow }}
cache-from: type=registry,ref=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:buildcache
cache-to: type=registry,ref=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:buildcache,mode=max
push: true
# ziti controller always binds at /zac and trailing slash is necessary to qualify Angular runtime paths in index.html
build-args: |
Expand Down
5 changes: 2 additions & 3 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* Update release-notes.md with description/links to what has changed
* Create a PR to "main" with above changes (and merge with approval and completed checks)

## If releasing the ziti-console lib shared library
## If releasing the ziti-console-lib shared library

* Create a new Release in Github with the following release name and tag format "ziti-console-lib-vx.x.x"
* Add the contents of the release-notes to the release description
Expand All @@ -15,5 +15,4 @@
* Add the contents of the release-notes to the release description

* Publish release(s)
* Go to Actions Tab and make sure both "Create Releases" and "Deploy QuickStart Container" actions are triggered by release
* Once both actions are complete, tell people in the usual ways
* Go to Actions tab and look for failures triggered by the release.
Loading