Skip to content

fix crash if ctrl detail missing edge version #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekoby merged 2 commits into from
Apr 8, 2025
Merged

fix crash if ctrl detail missing edge version #850

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b31220
fix crash if ctrl detail missing edge version
ekoby Apr 8, 2025
151c352
update runners
ekoby Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion library/ziti_ctrl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ static void internal_ctrl_list_cb(ziti_controller_detail_array arr, const ziti_e
api_address *addr = NULL;
MODEL_LIST_FOREACH(addr, d->apis.edge) {
CTRL_LOG(VERBOSE, "%s/%s", addr->version, addr->url);
if (strcmp(addr->version, "v1") == 0) {
if (addr->version && strcmp(addr->version, "v1") == 0) {
break;
}
addr = NULL;
Expand All @@ -309,6 +309,7 @@ static void internal_ctrl_list_cb(ziti_controller_detail_array arr, const ziti_e
change = change || (old_detail->is_online != d->is_online);
}
} else {
CTRL_LOG(DEBUG, "ctrl[%s] has no edge/v1 endpoint", d->name);
free_ziti_controller_detail_ptr(d);
}
}
Expand Down
Loading