Conversation
avoid disconnecting edge router if controller has not refreshed ER model yet (usually after restart)
ekoby
force-pushed
the
ha-avoid-er-disconnects
branch
from
9ffb22e to
bf6ce4f
Compare
dovholuknf
approved these changes
May 5, 2025
Member
dovholuknf
left a comment
dovholuknf
left a comment
There was a problem hiding this comment.
possible to add tests around this at all? lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
avoid disconnecting edge router if controller has not refreshed ER model yet (usually after restart) -- TLS address may be missing
also, process possible ER advertised address changes
[fixes #861]