Skip to content

schedule re-bind if binding request fails #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ekoby merged 2 commits into from
May 22, 2025
Merged

schedule re-bind if binding request fails #874

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8dbfa1
schedule re-bind if binding request fails
ekoby May 22, 2025
e578f2b
Merge branch 'main' into rebind-on-failure
ekoby May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion library/bind.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,11 @@ static void schedule_rebind(struct ziti_conn *conn) {
return;
}

if (conn->server.rebinder.expire_cb != NULL) {
CONN_LOG(DEBUG, "re-bind already scheduled");
return;
}

int backoff = 1 << MIN(conn->server.attempt, 5);
uint32_t random;
uv_random(conn->ziti_ctx->loop, NULL, &random, sizeof(random), 0, NULL);
Expand Down Expand Up @@ -505,10 +510,12 @@ static void bind_reply_cb(void *ctx, message *msg, int code) {
(void (*)(void *, message *, int)) on_message);
b->state = st_bound;
} else {
CONN_LOG(DEBUG, "failed to bind on router[%s]", b->ch->name);
CONN_LOG(DEBUG, "failed to bind on router[%s]: %s", b->ch->name,
ziti_errorstr(code));
ziti_channel_rem_receiver(b->ch, b->conn_id);
b->ch = NULL;
b->state = st_unbound;
schedule_rebind(b->conn);
}
}

Expand Down
Loading