try to get complete chain if controller indicates an issue with current certificates#875
Merged
try to get complete chain if controller indicates an issue with current certificates#875
Conversation
restructure extension checks
dovholuknf
reviewed
May 22, 2025
library/ziti.c
Outdated
| // check if identity cert is expiring or expired | ||
| if (ztx->opts.cert_extension_window > 0) { | ||
| if (!api_sess->is_cert_extendable) { | ||
| ZTX_LOG(DEBUG, "identity certificate is not renewable"); |
Member
There was a problem hiding this comment.
seems more like a WARN to me
Member
Author
There was a problem hiding this comment.
i know you said it before, but it means it is a 3rd party cert, why warn about it?
Member
There was a problem hiding this comment.
LOL i thought it felt familiar... there's no way to discern if it's from the controller's pki or 3rd party?
dovholuknf
approved these changes
May 22, 2025
scareything
approved these changes
May 22, 2025
restructure extension checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.