Conversation
connect channel and wrap with socket directly
dovholuknf
reviewed
Mar 7, 2025
| it.addresses.any { it.matches(host) } && it.portRanges.any { r -> port in r.low..r.high } | ||
| } ?: false | ||
| } ?: false | ||
| (it.service.interceptConfig()?.matches(host, port) ?: false) |
Member
There was a problem hiding this comment.
i imagine we don't support wildcards right? not something to worry about?
Member
Author
There was a problem hiding this comment.
it does support wildcards. the check was moved to https://github.com/openziti/ziti-sdk-jvm/pull/677/files#diff-f08e5ccd169c44e7b709effdec8410cdbb71bfb96b289f8612ef16c73513dc3bR62
dovholuknf
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[fixes #676]
Test Improvements:
ConnectionTeststo test connection scenarios, including timeout and read operations.