fixes #1330 check for SANs conflicts on startup#3388
Open
andrewpmartinez wants to merge 1 commit intomainfrom
Open
fixes #1330 check for SANs conflicts on startup#3388andrewpmartinez wants to merge 1 commit intomainfrom
andrewpmartinez wants to merge 1 commit intomainfrom
Conversation
Member
andrewpmartinez
commented
Nov 21, 2025
andrewpmartinez
commented
- requires xweb dep update
- requires xweb dep update
dovholuknf
reviewed
Nov 21, 2025
| conflictsStr += conflict.Error() | ||
| } | ||
|
|
||
| return nil, fmt.Errorf("conflicting SANs found in root [identity] section server certificate, ensure each server certificate is the sole representation of each DNS/IP SAN: %s", conflictsStr) |
Member
There was a problem hiding this comment.
does it only check the root identity section? it'd have to synthesize all of them or does that happen during config-time?
Member
Author
There was a problem hiding this comment.
The other sections are xweb and handled by this PR: openziti/xweb#31
qrkourier
reviewed
Nov 21, 2025
Member
qrkourier
left a comment
qrkourier
left a comment
There was a problem hiding this comment.
In case of a misconfigured controller with at least one conflicting SAN, will upgrading to this revision cause the controller to abort/panic during startup, or emit a warning?
If the upgraded controller will no longer run when misconfigured, the steps to recover from the outage include reissuing the conflicting server certificates which are bound to the controller's TLS listeners, correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.