Skip to content

config type target #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plorenz wants to merge 8 commits into
base: main
Choose a base branch
from
Open

config type target #3745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
90b22ed
Add a doc about potential anycast support for links
plorenz Mar 26, 2026
cc73a83
Add an initial doc exploring controller managed router configuration
plorenz Mar 26, 2026
0b103ba
Updated with review comments and additions regarding collapsing the r…
plorenz Mar 27, 2026
6134f09
Update based on review feedback
plorenz Mar 28, 2026
b112045
More updates from review changes
plorenz Mar 28, 2026
1d4b665
Add a rough implementation plan
plorenz Mar 30, 2026
5288e9e
Add note on config permissions
plorenz Mar 30, 2026
08598e4
Add target field to config types. Fixes #3743
plorenz Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions CHANGELOG-v2.1.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# Release 2.1.0

## What's New

* Config Type Target Field

## Config Type Target Field

Config types now have an optional `target` field that indicates what kind of entity the config type
is intended for. Valid values are `"service"` and `"router"`. The field is set on creation and is
immutable afterward.

This is the first step toward controller-managed router configuration. The `target` field lets us
distinguish between config types meant for services and config types meant for routers, which keeps
UIs, APIs, and validation clean. See `doc/design/ctrl-managed-router-config.md` for the full design.

A database migration sets `target = "service"` on all existing config types. Services and identity
service config overrides now require that referenced configs have a config type with
`target = "service"`.

The CLI has been updated to support the new field:

* `ziti edge create config-type` now accepts a `--target` flag
* `ziti edge list config-types` now shows a `Target` column
17 changes: 14 additions & 3 deletions common/pb/edge_cmd_pb/edge_cmd.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions common/pb/edge_cmd_pb/edge_cmd.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ message ConfigType {
string name = 2;
bytes schema = 3;
map<string, TagValue> tags = 4;
optional string target = 5;
Copy link
Copy Markdown
Member

@andrewpmartinez andrewpmartinez Apr 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why optional? I assume this is for backward compatibility, but optional makes string be *string and doesn't really do much else besides letting us detect whether it was explicitly set or not. I don't see a reason to detect whether a setting is set or not.

I assume that the default is a target value of "service," and we could create an enum that does this:

enum ConfigTargetType {
  CONFIG_TYPE_SERVICE = 0;
  CONFIG_TYPE_ROUTER = 1;
}

Then the config type can be the enum type and default cleanly to 0 and not have to deal w/ pointer refs.

}

// Controllers
Expand Down
Loading
Loading